This project is archived and is in readonly mode.

#3496 ✓stale
JackC

ActiveResource should use Rails time zone support instead of forcing UTC

Reported by JackC | November 19th, 2009 @ 04:11 PM

ActiveRecord can automatically convert times from UTC in the database to the local time zone. ActiveResource automatically converts times it receives over the wire to UTC. ActiveResource should instead convert times to the local time zone.

The underlying behavior is actually in ActiveSupport's Hash.from_xml method.

I'm currently overriding this with the following in an initializer.

xml_parsing = ActiveSupport::CoreExtensions::Hash::Conversions::XML_PARSING
xml_parsing["datetime"] = Proc.new  { |time| (::Time.parse(time) rescue ::DateTime.parse(time)).in_time_zone }
xml_parsing["dateTime"] = xml_parsing["datetime"]

Comments and changes to this ticket

  • ben.talberg (at appcanny)

    ben.talberg (at appcanny) August 25th, 2010 @ 05:57 PM

    • Importance changed from “” to “”

    +1 I ran into this problem reading dates from an API call. I'm using from_xml and dates lose timestamp detail:

    Expected:
    "2010-08-25T10:36:24-05:00"

    Because of UTC function:
    "2010-08-25T15:36:24Z"

  • ben.talberg (at appcanny)

    ben.talberg (at appcanny) August 25th, 2010 @ 06:20 PM

    I used this file to override the default time conversion function. Maybe will help someone out if they run into this problem as well.

  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:33 PM

    • State changed from “new” to “open”

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:33 PM

    • State changed from “open” to “stale”

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

People watching this ticket

Attachments

Pages