This project is archived and is in readonly mode.
[PATCH] Support for highlighting with ignoring special chars.
Hi!
I've created a patch for TextHelper::highlight that adds an option :ignore_special_chars, usable for highlighting strings that contain special characters with queries without special characters and vice-versa.
Example:
highlight('Šťabajzna', 'stabajzna', :ignore_special_chars => true)
# => <strong class="highlight">Šťabajzna</strong>
BTW don't know why but:
haystack = ActiveSupport::Multibyte::Chars.new(haystack).normalize(:kd)
haystack = haystack.mb_chars.normalize(:kd) # not working on Windows without $KCODE = 'u'
-
Michal HantlCool!
-
VojtoVery useful for non-english speaking countries.
-
johno
For anyone wondering about what is this good for.
It ignores special characters like national alphabets when highlighting strings. (e.g. Štabajzna would also highlight stabajzna.)
Normally users search without using special characters with accents, umlauts... but when you try to highlight matches in search results with current implementation of
highlightyou are out of luck. -
Santiago Pastorino
- State changed from new to open
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
Santiago Pastorino
- State changed from open to stale