Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

ActionMailer generates incorrect functional tests

#3780

ActionMailer generators create incorrect functional tests:

assert_equal @expected.encoded, OrderMailer.create_sent(@expected.date).encoded

This was using #encoded before, but this is incorrect and was done to handle a TMail short-coming.

assert_equal @expected, OrderMailer.create_sent(@expected.date)

Tests the same thing and will work (as mail will ignore a diff on message-id if EVERYTHING else is the same.

Reported by Mikel Lindsaar · January 24th, 2010 @ 08:09 AM

State: resolved
Milestone: 3.0.2
Assigned to: Mikel Lindsaar Mikel Lindsaar
Importance: Low

Activity

  1. Mikel Lindsaar
    Mikel Lindsaar
    • State changed from new to verified

    I have patched my fork on commit #c9dc1ac. Will merge soon.

    January 24th, 2010 @ 08:10 AM

  2. Mikel Lindsaar
    Mikel Lindsaar
    • State changed from verified to resolved

    Fixed in the merge of the new Action Mailer #abad09701 rails/rails

    January 26th, 2010 @ 07:00 AM

  3. Jeremy Kemper
    Jeremy Kemper
    • Milestone set to 3.0.2
    • Importance changed from to Low

    October 15th, 2010 @ 11:01 PM