This project is archived and is in readonly mode.

#3802 ✓wontfix
Ryan Bigg

[PATCH] Remove useless require

Reported by Ryan Bigg | January 28th, 2010 @ 06:52 AM | in 3.0.2

In railties/lib/rails/application.rb there's a require 'rails/plugin' which then does require 'rails/engine', then back in application.rb there's another call to require 'rails/engine' which doesn't need to be there because plugin.rb already has it.

Patch attached!

Comments and changes to this ticket

  • Rizwan Reza

    Rizwan Reza January 28th, 2010 @ 01:52 PM

    • State changed from “new” to “verified”
    • Tag changed from 3.0, 3.0pre, railties to 3.0, 3.0pre, patch, railties
    • Assigned user set to “José Valim”
    • Milestone cleared.

    +1 verified, makes sense. Applied it to master and does so cleanly.

  • José Valim

    José Valim January 28th, 2010 @ 02:06 PM

    • State changed from “verified” to “wontfix”

    In my opinion, the application object should not be concerned if a plugin is an engine or not (it was not true until some days ago) since the only API the application uses from plugins is: "Plugin.all". Usually we have some extra requires, but this one is there intentionally. :) Thanks for checking this area guys!

  • Jeremy Kemper

    Jeremy Kemper October 15th, 2010 @ 11:01 PM

    • Milestone set to 3.0.2
    • Importance changed from “” to “Low”

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href=""></a>

People watching this ticket