This project is archived and is in readonly mode.
[PATCH] Remove useless require
#3802
In railties/lib/rails/application.rb there's a
require 'rails/plugin' which then does require
'rails/engine', then back in application.rb there's
another call to require 'rails/engine' which doesn't
need to be there because plugin.rb already has it.
Patch attached!
-
Rizwan Reza- State changed from new to verified
- Tag changed from 3.0, 3.0pre, railties to 3.0, 3.0pre, patch, railties
- Assigned user set to José Valim
- Milestone cleared.
+1 verified, makes sense. Applied it to master and does so cleanly.
-
José Valim- State changed from verified to wontfix
In my opinion, the application object should not be concerned if a plugin is an engine or not (it was not true until some days ago) since the only API the application uses from plugins is: "Plugin.all". Usually we have some extra requires, but this one is there intentionally. :) Thanks for checking this area guys!
-
