This project is archived and is in readonly mode.
UploadedTestFile should respond_to? :read and other tempfile methods
I discovered this bug while testing file uploading in an app I'm working on. While accessing the uploaded data I'm differentiating between String and StringIO/TempFile by checking if the object respond_to?(:read). In testing with TestUploadedFile I discovered that it does not correctly report that it respond_to?(:read) as this is handled through method missing. This patch runs the respond_to? on the tempfile as well as the TestUploadedFile yielding a result that more closely matches what you see in an actual request.
-
Nikos Dimitrakopoulos- Tag set to bug, patch, testing
This bit me too and I was about to send a similar patch.
+1
Thanks Will
-
Nikos Dimitrakopoulos
One fix to your patch: you should use original_respond_to instead of respond_to.
-
José ValimI believe there is no need to use aliases, you can simply call super.
-
Santiago Pastorino- State changed from new to open
- Importance changed from to Low
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
Santiago Pastorino
- State changed from open to stale