Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

error_message_on closes parent tag

#3943

I have the following simple form:

<% form_for(form, :url => root_path) do |f| %>
<p>
  <%= f.label :name %>
  <%= f.error_message_on :name %>
  <%= f.text_field :name %>
</p>
...

Each label/input is enclosed in a paragraph tag. When this is initially rendered, I see the expected HTML:

<form action="/" class="new_user_invite" id="new_user_invite" method="post">
<!-- auth token.... -->
<p>
  <label for="user_invite_name">Name</label>
  
  <input id="user_invite_name" name="user_invite[name]" size="30" type="text">
</p>
...

However, if there is an error on this field, I end up with the following HTML:

<form action="/" class="new_user_invite" id="new_user_invite" method="post">
<!-- auth token ... -->
<p>
  </p><div class="fieldWithErrors"><label for="user_invite_name">Name</label></div>
  <div class="formError">can't be blank</div>
  <div class="fieldWithErrors"><input id="user_invite_name" name="user_invite[name]" size="30" value="" type="text"></div>
...

As you can see, the validation error on this field causes the

tag to be closed before the label & input HTML is generated. This obviously is not what is expected here.

I'm using rails 2.3.5, rack 1.0.1 and rake 0.8.7.

Reported by Mike Heffner · February 12th, 2010 @ 09:34 PM

State: stale
Milestone: none
Assigned to: nobody
Importance: none

Activity

  1. Mike Heffner
    Mike Heffner

    Second to last sentence was intended to be (chopped the html tag):

    As you can see, the validation error on this field causes the paragraph tag to be closed before the label & input HTML is generated. This obviously is not what is expected here.

    February 12th, 2010 @ 09:35 PM

  2. Santiago Pastorino
    Santiago Pastorino
    • State changed from new to open

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

    February 2nd, 2011 @ 04:55 PM

  3. Santiago Pastorino
    Santiago Pastorino
    • State changed from open to stale

    February 2nd, 2011 @ 04:55 PM