This project is archived and is in readonly mode.
[PATCH] Join conditions removed on habtm and has many through with conditions or STI
When utilizing a JoinDependency to load a habtm or has many through association that uses conditions and/or an STI target class that is not the base class, at least the join condition is lost producing incorrect results.
I have provided a patch that is split into 2 commits. The first commit alters the posts.yml and comments.yml fixtures and fixes the tests theses changes break. The second commit presents a new failing test case and the fix.
-
David Genord IIFound another point of failure and updated the patch
-
David Genord II
- Tag changed from activerecord associations, 3.0pre, activerecord, rails3 to activerecord associations, 3.0pre, activerecord, patch, rails3
-
Will BryantDavid, is this still an issue on master?
-
David Genord II
Yes it is still an issue but the patch is going to change drastically. I should have it ready shortly.
-
-
Rohit Arondekar- Tag changed from activerecord associations, 3.0pre, activerecord, patch, rails3 to 3.0pre, activerecord, associations, patch, rails3
-
Jon Leighton- Assigned user set to Aaron Patterson
This is no longer an issue and so it can be closed.
I've run both of David's tests and they work. It's already covered by
test_eager_with_has_many_through_join_model_with_conditions_on_top_levelineager_test.rb. -
Jon Leighton
- State changed from new to resolved
- Importance changed from to Low