This project is archived and is in readonly mode.
Monkey patched ERB breaks other libraries relying on standard behaviour from ERB.
-
Aslak HellesøyI have added a test to reproduce this here: http://github.com/aslakhellesoy/rails/commit/13d11f7b7033fee328d99c...
The fix is here: http://github.com/aslakhellesoy/rails/commit/30416d3cdc6863af444ea9...(Those two commits should ideally have been done in the opposite order, but you get the idea).
The fix is on my 2-3-stable-4034-dont-monkeypatch-erb branch
-
Aslak Hellesøy
FWIW - here is the original ticket that was reported in Cucumber. It has a link to a gist that shows an example of how this bug manifests itself.
https://rspec.lighthouseapp.com/projects/16211/tickets/577-breakage...
-
José Valim- Assigned user set to Yehuda Katz (wycats)
- Milestone cleared.
-
Yehuda Katz (wycats)- State changed from new to open
Aslak, this patch looks good. Can you rebase against master?
-
José Valim
- State changed from open to invalid
The hacks were removed in master. Aslak, please reopen if you find more issues!
-
Jeremy Kemper- Milestone set to 2.3.7
- State changed from invalid to incomplete
But the hacks were not removed from 2-3-stable.
-
-
Jeremy Kemper
- State changed from incomplete to resolved
-
Aslak Hellesøy
Thanks guys!