This project is archived and is in readonly mode.

#4118 ✓committed
Aaron Patterson

ActiveRecord::QueryMethods.build_where can be written better

Reported by Aaron Patterson | March 6th, 2010 @ 09:20 PM

ActiveRecord::QueryMethods calls first on *args many times, and can also take advantage of case / when statements rather than calling is_a?.

I've attached a patch that cleans up the code a bit.

Comments and changes to this ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

People watching this ticket

Attachments

Pages