This project is archived and is in readonly mode.

ActiveRecord#find uses :first Cache for :all when options exist

#4305

When doing a #find :first followed by a #find :all with identical options, the find :all incorrectly uses an AR Cache of :first containing "LIMIT 1". This only happens when there are options and when :first precedes :all.

For example, with this in an action:

  opts = { :order => :name }
  @user = User.find(:first, opts)
  @users = User.find(:all, opts)

the log shows:
[4;36;1mUser Load (0.6ms) [0m [0;1mSELECT * FROM "users" ORDER BY name LIMIT 1 [0m

[4;35;1mCACHE (0.0ms) [0m [0mSELECT * FROM "users" ORDER BY name LIMIT 1 [0m

Seen in Rails 2.3.5.
Update: Not seen in 3.0.9.

Reported by michaelmell · March 31st, 2010 @ 11:56 PM

Activity

Santiago Pastorino
- State changed from new to open
This issue has been automatically marked as stale because it has not been commented on for at least three months.

The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

February 2nd, 2011 @ 04:44 PM
Santiago Pastorino
- State changed from open to stale
February 2nd, 2011 @ 04:44 PM