#4392 [PATCH] Add :touch option to has_one associations - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#4392 ✓wontfix

[PATCH] Add :touch option to has_one associations

Reported by Diego Carrion | April 14th, 2010 @ 07:19 AM

Hi, I have a model with some children that should be updated when the parent change, it would be nice to have this feature in Rails.

Comments and changes to this ticket

You flagged this item as spam.
Diego Carrion April 14th, 2010 @ 07:25 AM
Patch is attached.
You flagged this item as spam.
Diego Carrion April 14th, 2010 @ 07:28 AM
- Tag set to “activerecord, has_many, rails, touch”
You flagged this item as spam.
Diego Carrion April 14th, 2010 @ 07:35 PM
- Title changed from “Add :touch option to has_many associations” to “[PATCH] Add :touch option to has_many associations”
You flagged this item as spam.
Diego Carrion April 15th, 2010 @ 03:24 PM
- Assigned user set to “Ryan Bigg”
Ryan Bigg April 15th, 2010 @ 03:26 PM
- Assigned user cleared.
I am not responsible for applying patches, sorry.
You flagged this item as spam.
Diego Carrion April 18th, 2010 @ 12:46 AM
- Tag changed from “activerecord, has_many, rails, touch” to “activerecord, has_many, patch, rails, touch”
You flagged this item as spam.
Diego Carrion April 19th, 2010 @ 01:43 AM
Some people on the list gave me some feedback and because of that I added also the touch support for has_one associations.

A new patch is attached.
You flagged this item as spam.
Diego Carrion April 19th, 2010 @ 01:44 AM
- Tag changed from “activerecord, has_many, patch, rails, touch” to “activerecord, has_many, has_one, patch, rails, touch”
Some people on the list gave me some feedback and because of that I added also the touch support for has_one associations.

A new patch is attached.
You flagged this item as spam.
Diego Carrion April 19th, 2010 @ 01:44 AM
- Title changed from “[PATCH] Add :touch option to has_many associations” to “[PATCH] Add :touch option to has_many and has_one associations”
You flagged this item as spam.
Diego Carrion April 19th, 2010 @ 01:50 AM
- Title changed from “[PATCH] Add :touch option to has_many and has_one associations” to “[PATCH] Add :touch option to has_many associations”
Sorry, I forgot the RDoc documenation in the previous patch, added a new one.
- add_touch_option_to_has_many_and_has_one.patch 13.3 KB
Michael Koziarski April 19th, 2010 @ 10:00 PM
As discussed on the mailing list, I don't believe that the feature is justified for the sake of consistency alone. It would hide severe performance issues inside a simple declaration.

People needing this functionality can write a tiny after_save themselves.
Michael Koziarski April 19th, 2010 @ 10:00 PM
- State changed from “new” to “wontfix”
As discussed on the mailing list, I don't believe that the feature is justified for the sake of consistency alone. It would hide severe performance issues inside a simple declaration.

People needing this functionality can write a tiny after_save themselves.
You flagged this item as spam.
Diego Carrion April 20th, 2010 @ 01:14 AM
- Title changed from “[PATCH] Add :touch option to has_many associations” to “[PATCH] Add :touch option to has_one associations”
As discussed with Michael via the mailing list, the touch option for the has_one association does make sense so Im sending a patch.

I added also a test covering the scenario where the associated object doesn't exists, given that the validation was in the code but after deleting it, nothing broke.
- add_touch_support_for_has_one_associations.patch 8 KB