Rails Ruby on Rails

Comments and changes to this ticket

• 

  Ryan Bigg April 24th, 2010 @ 10:58 AM

  It would be better if this option was called default_protocol rather than default_proto. Could you also try applying this patch to master and writing some tests for it?

• You flagged this item as spam.
  

  rabbitt April 24th, 2010 @ 08:05 PM

  Sure thing - I'll put something together by Monday or Tuesday.

  Cheers!,

  -- Carl

• 

  Neeraj Singh April 25th, 2010 @ 12:15 PM

  Attached is code patch against rails3 edge.

  Could not add any test because introduction of app.config is causing problem and I don't really know how to inject app in the concerned class/module in test environment. If anyone has any tips on how to write test then let me know.

  • site_wide_default_protocol_against_rails3_edge.diff 2 KB
• 

  Santiago Pastorino February 2nd, 2011 @ 04:43 PM

  • State changed from “new” to “open”
  • Importance changed from “” to “Low”

  This issue has been automatically marked as stale because it has not been commented on for at least three months.

  The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

  Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

• 

  Santiago Pastorino February 2nd, 2011 @ 04:43 PM

  • State changed from “open” to “stale”