Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Rails 3.0 encoding fixes for unit tests

#4473

I'm trying to get Rails 3.0 tests to work with any combination of Ruby (1.8.7, 1.9.1, ruby-head) and Ruby standard encoding (-Ku -Kn -Ks -Ke and no option).

The possibility to run any such combination will help Rails encoding support by:

  • testing for encoding correctness without the need for more test cases
  • helping find missing encoding comments in source files
  • detecting bad encoding assumptions, etc.
  • preventing encoding regressions unnoticeable otherwise
  • helping users create more robust and helpful patches

Reported by Cezary Baginski · April 25th, 2010 @ 06:45 PM

State: committed
Milestone: 3.0.2
Assigned to: nobody
Importance: Low

Activity

  1. Cezary Baginski
    Cezary Baginski

    The following patch for actionpack contains:

    • Ruby 1.8.7 -Ke/-Ks interpretable UTF-8 string
    • Ruby 1.9.1-p378 symbol lookup workaround
    • UTF-8 regex for Ruby 1.8.7 -Ke/-Ks

    April 25th, 2010 @ 06:54 PM

  2. Cezary Baginski
    Cezary Baginski

    As for activesupport:

    ruby 1.9.1p378 (r26273) is too old to run the unit tests, because of the bug in the String methods (rjust, ljust, center, etc).

    The minimal rev seems to be: r26568, which fixes this.

    1.9.1-head works (1.9.1p420), not mentioning a tiny patch is needed.

    April 26th, 2010 @ 12:12 AM

  3. Repository
    Repository
    • State changed from new to committed

    (from [490a3335d56c124c8113aac0b63ad367f81bb450]) Action Pack: fix tests with -K*, work around Ruby 1.9.1 constant lookup.

    [#4473 Rails 3.0 encoding fixes for unit tests state:committed]

    Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
    http://github.com/rails/rails/commit/490a3335d56c124c8113aac0b63ad3...

    April 26th, 2010 @ 01:09 AM

  4. Jeremy Kemper
    Jeremy Kemper
    • Milestone set to 3.0.2
    • Importance changed from to Low

    October 15th, 2010 @ 11:01 PM