Rails::Generators::GeneratedAttribute: tests, cleanups and a bugfix

Sorry about that, and thanks Ryan for changing state to open. Will take care not to repeat this again.

Checked the trailing whitespace problem out, seemed that there were some trailing spaces in railties/test/generators/generated_attribute_test.rb. Here's a new patch. :)

One test fails on 1.9.2-head, see => http://pastie.org/969479
It appears that in 1.9.2 Proc doesn't have marshal_dump defined. But playing in irb I noticed both 1.8.7 and 1.9.2-head, Proc doesn't have marshal_dump defined, so where is it coming from?

Someone might want to look at marshal.rb in activesupport, it has some 1.9.2 stuff in it, I don't know if it's relevant though.

I made a mistake in my original comment, I had tested on 1.8.7 and not 1.9.2-head.

I can't seem to reproduce Rohit's test fail on master with and without the patch on Ruby 1.8.7-p249 and 1.9.1-p376.

Can anybody else reproduce this? Also, isn't it really unlikely that my patch would cause this?

I had tested on 1.9.2-head. I tried again both before and after applying the patch and all tests pass.

P.S I have no idea why it failed the last time, maybe my environment is borked. :(

+1 tests pass (1.8.7)

One thing, is it right to replace then Date.today.to_s(:db) with then Date.today.to_s?

If I recall correctly, Date object also supported .to_s(:db).

Anil was right, I've put .to_s(:db) back, and included active_support/time in Rails::Generators::GeneratedAttribute. Here's a new patch. :)

+1 Tests pass on
ruby 1.9.2dev (2010-05-08 trunk 27665)
ruby 1.8.7 (2009-06-12 patchlevel 174)

Like the DRY'ing up and the tests look cleaner.

+1 for me too on 1.8.7. Agree with Rohit. Like the code refactoring to make it more DRY.