This project is archived and is in readonly mode.

#4720 ✓stale
Norman Clarke

Move check for expected result size into separate method

Reported by Norman Clarke | May 28th, 2010 @ 06:23 PM

ActiveRecord::FinderMethod#find_some currently does two things: (1) fetches a result set, and then (2) checks to make sure the result size matches the expected size. This patch moves that check into a separate method.

The patch I'll attach refactors this into two methods. Why? Well, for several years I've needed this functionality in my friendly_id plugin, and I'd love to be able to rely on a method in AR for this rather than continue to copy and paste from AR. I assume if I need this, other plugin authors will as well. Since the change simply composes a long, protected method into two more focused ones, I thought it would be a pretty simple and reasonable modification.

Comments and changes to this ticket

  • Norman Clarke
  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:52 PM

    • State changed from “new” to “open”

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:52 PM

    • State changed from “open” to “stale”

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href=""></a>

People watching this ticket