This project is archived and is in readonly mode.
[PATCH] ActionController::Dispatcher fix for handling of ApplicationController load errors
dispatcher.rb in dispatch contains
if controller ||= (::ApplicationController rescue
Base) line which is supposed to fall back to
ActionController::Base in case of any error in loading
of ApplicationController.
This form of rescue catches only
RuntimeErrors, while any LoadError or
SyntaxError (which are derived from
Exception) pass this trap and
ActionController::Base.call_with_exception doesn't get
called. The first original exception then gets shadowed by such
LoadError. In some cases these two exceptions can be
different.
This bug in combination with #4731 [PATCH] fix ActiveSupport::Dependencies removes properly loaded classes neste... can
lead to completely misleading backtraces. In the case described in
that ticket, the first exception was accurate
(SyntaxError with file and line number), while
subsequent try to load ApplicationController in
dispatch was throwing "Expected
app/helper/admin/some_helper.rb to define Admin::SomeHelper" while
some_helper.rb was in perfect shape.
Please find proposed patch attached.
Thanks
Serge
-
Michael Koziarski- Milestone set to 2.3.9
-
-
Santiago Pastorino- State changed from new to open
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
Santiago Pastorino
- State changed from open to stale