This project is archived and is in readonly mode.

#479 ✓invalid
Ernie Miller

Regexp selection of priority zones in time_zone_select

Reported by Ernie Miller | June 25th, 2008 @ 04:00 AM

Per Geoff Buesing's request in #195, this patch implements =~ on ActiveSupport::TimeZone for selection of zones based on a match of name or TZInfo identifier in the MAPPING hash for easier localization. I had to flesh out the TimeZone mock a little more for testing, there may well be a better way to do this because this is my first Rails patch submission.

I'd really appreciate any input.

Comments and changes to this ticket

  • Jeremy Kemper

    Jeremy Kemper June 25th, 2008 @ 04:20 AM

    • State changed from “new” to “invalid”

    Hey Ernie, the patch looks good to me, but could you attach it to the original ticket? Let's keep work on this issue in one place. Thanks :)

  • Ernie Miller

    Ernie Miller June 25th, 2008 @ 04:24 AM

    Sure. Sorry. Was going to, but instructions for submitting patches called for creating a ticket with the tag patch. Just following directions. ;D

  • Ernie Miller

    Ernie Miller June 25th, 2008 @ 04:28 AM

    Actually, I'm just stupid. It said "Attach the patch to a lighthouse ticket and add the patch tag." Never said I needed to create the ticket. :) Anyway, updating now.

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

Attachments

Tags

Referenced by

Pages