This project is archived and is in readonly mode.
[PATCH] Migrations with Improper Names Generate Invalid Code
-
sabat (at area51)
- Tag changed from beta4 migrations template to beta4, migrations, template
Fixed patch: I hadn't followed the rules for generating it. Sorry. :-o
-
sabat (at area51)
- Title changed from Migrations with Improper Names Generate Invalid Code to [PATCH] Migrations with Improper Names Generate Invalid Code
-
sabat (at area51)
Fixed a minor formatting problem in previous version of patch.
-
Rohit Arondekar
- Milestone set to 3.x
- Tag changed from beta4, migrations, template to rails 3, activerecord, migrations, template
- State changed from new to open
- Assigned user set to José Valim
Confirmed issue on Rails master.
Patch applies cleanly, and solves the problem.
However does the change require tests?
-
José Valim
I need to apply this for the upcoming release. Could someone please work on tests? :)
-
Rohit Arondekar
I had a go at it. Ended up adding only one test. Feedback required. :)
Aside: I found a failing test in Railties, http://pastie.org/1011980 Might not have the time to investigate today, will do ASAP.
-
José Valim
Yes, this test is failing on purpose. There is a tip, you can always run just generator tests with:
rake test TEST_DIR=generatorsinside the railties dir. Your test looks good Rohit, I will apply both patches soon! :) -
Repository
- State changed from open to committed
(from [d06105063829d44adf641059ef97f54d7b690f4b]) Add test for migration generator with name not starting with add or remove. [#4835 [PATCH] Migrations with Improper Names Generate Invalid Code state:committed]
Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/d06105063829d44adf641059ef97f5... -
Rohit Arondekar
Jose, thanks for the tip. Btw my patch didn't include the original fixing patch so that will have to be applied separately.
-
José Valim
Yup, I applied both!
-
Rohit Arondekar
Oh my bad, the patch didn't have a reference to this ticket. :)
In case anyone is looking for the commit -> http://github.com/rails/rails/commit/451594784552bd6955687d8ff617c4...
