Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

[PATCH] ActionDispatch MemCacheStore violates encapsulation principle

#4842

When pass :cache param to ActionDispatch::Session::MemCacheStore, it should be removed from options, otherwise it remains "published". This violates the OOP encapsulation principle.

I attached a patch for this issue.

Reported by Luca Guidi · June 12th, 2010 @ 11:29 AM

State: wontfix
Milestone: none
Assigned to: nobody
Importance: none

Activity

  1. Michael Koziarski
    Michael Koziarski
    • State changed from new to wontfix

    We don't generally modify argument hashes otherwise it breaks code which uses a single hash passed to multiple constructors. e.g. 5.times { Whatever.new(@options) }

    June 13th, 2010 @ 06:22 AM