Refactor build_arel

The last change in the attached patch is

- arel = @from_value.present? ? arel.from(@from_value) : arel.from(@klass.quoted_table_name)
+ arel = arel.from(@from_value) if @from_value.present?

I have not analyzed the code fully but based on cursory look, it seems to me that a call to arel.from(@klass.quoted_table_name) is missing in else condition.

No, there's no need to do that, that's why i didn't include it.

It's just creating another new relation that will end up creating the same.

If there's an edge case that i'm missing please let me know, all tests are passing with the patch, so if there's any issue that is introduced with this patch please let me know so i can change it and add proper tests.

Oh, José both patches should be applied ;)

José,

I applied build_arel_2.diff in a fresh master, I don't know why you couldn't.

I attach a new patch with same changes, hope this time works for you.

Thanks!