This project is archived and is in readonly mode.

#4864 ✓stale
Victor Garcia

Strange behavior with page.insert_html

Reported by Victor Garcia | June 15th, 2010 @ 06:18 AM

I have a create.rjs file that does the following:

page.insert_html :top, :blist_tbody, :partial => 'my_partial_file', :object => @myobj

my_partial_file looks like the following:

<% show_full = false if show_full.nil? #flag to show/hide all info by default %>
<tr class="class1 class2 page_<%= !@page.blank? ? @page : 1 %> <%= cycle("odd", "even") %>" id='obj_id_<%=myobj.id%>'>
...

When this runs, and inserts this into the page it strips out all of the stuff before the !@page.blank... part, so the html inserted in the page looks like so:

1 odd" id='obj_id_123'>...

instead of

<tr class="class1 class2 page_1 odd" id='obj_id_123'>...

if I change the first line of the partial file by removing the inline comment or changing the closing rails tag to -%> instead of %> it works fine.

doesn't work:

<% show_full = false if show_full.nil? #flag to show/hide all info by default %>

works:

<% show_full = false if show_full.nil? %>
<% show_full = false if show_full.nil? #flag to show/hide all info by default -%>

Did not notice this behavior before version 2.3.6

Comments and changes to this ticket

  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:37 PM

    • State changed from “new” to “open”

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:37 PM

    • State changed from “open” to “stale”

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

People watching this ticket

Pages