This project is archived and is in readonly mode.
Fail to force_reload polymorphic associations
-
BertgCurrent test is not valid, working on a valid one. Sorry guys/girls.
-
Bertg
- Tag changed from rails 3.0.0.beta4, associations, belongs_to, polymorphic, testcase to rails 3.0.0.beta4, associations, belongs_to, cache, polymorphic, testcase, uncached
Created a working testcase (test.diff).
This test proves that polymorphic associations fail to force_load.assert_nothing_raised { sponsor.sponsorable(true) }
fails
I also added a suggestion fix, which solves the NameError.
However, the query is not repeated and thus a following test fails.assert_queries(1) { assert_not_nil sponsor.sponsorable(true) }
fails
The solution I propose is to move the uncached method to the reflection and let it handle the uncaching.
An other solution could be that reflections on polymorphic associations return a value when klass is called.-
test.diff
819 Bytes
-
suggestion.diff
1.53 KB
-
Bertg
- Tag changed from rails 3.0.0.beta4, associations, belongs_to, cache, polymorphic, testcase, uncached to rails 2.3.8, rails 3.0.0.beta4, associations, belongs_to, cache, polymorphic, testcase, uncached
-
Bertg
- Tag changed from rails 2.3.8, rails 3.0.0.beta4, associations, belongs_to, cache, polymorphic, testcase, uncached to rails 2.3.8, rails 3.0.0.beta4, associations, belongs_to, bug, cache, patch, polymorphic, regression, testcase, uncached
-
DHH- Assigned user set to Pratik
-
Bertg
- Importance changed from to Low
Is there a way I can help resolve this problem?
I can build a fix, but i just need to know "how" to design it. Currently the problem lays in "reflection.klass" not always returning a class.
Either the solution would not use "reflection.klass" but directly "reflection.uncached" (as suggested) or polymorphic associations should return a "polymorphic" class.
Priority should also be higher than "Low" as this is a regression bug.
-
StaszekI have also has this problem.
My suggestion is to change 'klass' or 'class_name' method from AssociationReflection. I think there is the problem. Changing whole uncached method is too wide solution.Problem exists in rails >2.3.5 version
-
rails- Tag changed from rails 2.3.8, rails 3.0.0.beta4, associations, belongs_to, bug, cache, patch, polymorphic, regression, testcase, uncached to rails 238, rails 300beta4, associations, belongs_to, bug, cache, patch, polymorphic, regression, testcase, uncached
- State changed from new to open
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
rails
- State changed from open to stale