This project is archived and is in readonly mode.
truncate should always return unsafe strings
-
Wincent ColaiutaProposed fix pushed to the "ticket4878" branch of my fork:
http://github.com/wincent/rails/tree/ticket4878
Specifically, this commit:
http://github.com/wincent/rails/commit/157db6a2f7df1924f0c738fa4ac1...
I've modified the tests, but I am having trouble running the test suite on this machine so I'd appreciate it if someone could confirm that this is correct.
-
Wincent Colaiuta
Ok, fixed the problems in my test environment. Confirmed that everything passes.
-
-
Santiago Pastorino
- State changed from new to verified
+1 yesterday i did the patch and is the same as yours, but i'm attaching the patch again maintaining Wincent as the author of the original patch with one more test for excerpt method that shouldn't return safe too, so please someone of the core go ahead and apply it ;).
-
Repository
(from [7240a960f2e515316ac4d962482f678b67b83b8c]) excerpt shoudn't return safe output test added
[#4878 truncate should always return unsafe strings]
Signed-off-by: David Heinemeier Hansson david@loudthinking.com
http://github.com/rails/rails/commit/7240a960f2e515316ac4d962482f67... -
DHH- State changed from verified to committed
-
Wincent Colaiuta
Still not fixed though.
Commit 7240a960 contains only Santiago's additional test for the "excerpt" method.
Missing is my patch, the one which actually addresses the subject of this ticket ("truncate should always return unsafe strings").
-
Rohit ArondekarWincent, actually it does include the patch. http://github.com/rails/rails/commit/a424808df95c5ebe66d02f0d743e74...
-
Wincent Colaiuta
Ah, cool.
-
