This project is archived and is in readonly mode.
[PATCH] Add :notice, :alert, and :flash as options to render.
DHH added :notice, :alert and :flash as options to redirect_to, each of which set the flash hash before performing the redirect:
http://github.com/rails/rails/commit/e6cadd422b72ba9818cc2f3b22243a...
This patch gives the same options to render, setting values in flash.now. This gives the rendering/redirecting api some consistency. Tests are included, and everything passes on master.
-
render_flash_options.diff
2.76 KB
-
José Valim- State changed from new to wontfix
Thanks for your patch but tendering flash.now messages with a template is not a common pattern in most Rails applications. That said, I would prefer to leave the rendering stack simpler without need to check for extra flash keys.
-
Sean- Importance changed from to Low
Any chance of reconsidering? This may a worthy addition. Flashing notices while rendering is I believe not uncommon (since it usually mean recycling the page due to an error). It also adds consistency between redirect_to and render.
-
AdamThis is definitely a common pattern in most rails application I have authored or edited. I'll be stealing it for my personal use at very least. Thanks anyway. (PS, found this by googling knowing about the update to redirect_to).
-
PreciousBodilyFluids
Thanks, at least someone will get some use out of it.
-
Adam
wrapped in a gem for convenience: http://rubygems.org/gems/flash_render