This project is archived and is in readonly mode.

assign_nested_attributes_for_collection_association should accept minimum limits

#5022

# activerecord/lib/active_record/nested_attributes.rb

def assign_nested_attributes_for_collection_association(association_name, attributes_collection)
  options = nested_attributes_options[association_name]
  # ...
  if options[:limit] && attributes_collection.size > options[:limit]
    raise TooManyRecords, "Maximum #{options[:limit]} records are allowed. Got #{attributes_collection.size} records instead."
  end
  # ...
end

This function should be able to accept minimum limits in addition to maximum limits, and raise TooFewRecords exceptions.

Reported by Aaron Lifton · June 30th, 2010 @ 11:06 PM

Activity

Aaron Lifton

Here's my solution:

Instead of options[:limit], there would be options[:lower_limit] and options[:upper_limit], so both directions could be taken into account.

Then the code would be:

if options[:upper_limit] && attributes_collection.size > options[:upper_limit]
    raise TooManyRecords, "Maximum #{options[:upper_limit]} records are allowed. Got #{attributes_collection.size} records instead."
end
if options[:lower_limit] && attributes_collection.size < options[:lower_limit]
    raise TooFewRecords, "Minimum #{options[:lower_limit]} records are allowed. Got #{attributes_collection.size} records instead."
end

Is TooFewRecords even implemented?

July 3rd, 2010 @ 09:27 PM

Santiago Pastorino
- State changed from new to open
This issue has been automatically marked as stale because it has not been commented on for at least three months.

The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

February 2nd, 2011 @ 05:01 PM
Santiago Pastorino
- State changed from open to stale
February 2nd, 2011 @ 05:01 PM