This project is archived and is in readonly mode.
FormBuilder date helpers ignore html_options
It turned out that the form builder (f.) helpers of date_select, datetime_select and time_select ignore the html_options you pass to it.
They do work for the normal helper from DateHelpers class however, the problem is that the html_options hash simply gets not passed through to them in their form builder definitions.
Some Rails developers apparently need more coffee. ;-)
-
date_helpers.patch
1.12 KB
-
Pratik- State changed from new to incomplete
Hey Pascal,
Could you please add tests as well ?
Thanks.
-
Pascal Ehlert- Tag changed from 2.1, actionpack, forms, helper, patch to 2.1, actionpack, forms, helper, patch, tests
Sorry for not including them in the first patch, I was a bit in a hurry earlier.
I have attached an updated version with tests. Hope this makes it into trunk soon.
-
date_helpers_with_tests.patch
16.1 KB
-
Pratik
- State changed from incomplete to open
-
Repository
(from [029a7455846cde2654958358a6fe354f236ade35]) Ensure FormBuilder date helpers respects html_options. [#506 state:resolved] [Pascal Ehlert]
Signed-off-by: Pratik Naik
-
Repository
(from [b416c6880bba538799513f4afd4125a0be8c2fb5]) Ensure FormBuilder date helpers respects html_options. [#506 state:resolved] [Pascal Ehlert]
Signed-off-by: Pratik Naik
Conflicts:
actionpack/test/template/date_helper_test.rb
-
Pascal Ehlert
Thanks for fixing, Pratik!
Shouldn't this ticket be closed now?
-
Pratik
- State changed from open to resolved