diff --git a/actionpack/lib/action_view/helpers/form_helper.rb b/actionpack/lib/action_view/helpers/form_helper.rb index 6302491..681b81b 100644 --- a/actionpack/lib/action_view/helpers/form_helper.rb +++ b/actionpack/lib/action_view/helpers/form_helper.rb @@ -964,9 +964,9 @@ module ActionView else add_default_name_and_id(options) end - hidden = tag("input", "name" => options["name"], "type" => "hidden", "value" => options['disabled'] && checked ? checked_value : unchecked_value) checkbox = tag("input", options) - (hidden + checkbox).html_safe + hidden = tag("input", "name" => options["name"], "type" => "hidden", "value" => options['disabled'] && checked ? checked_value : unchecked_value) + (checkbox + hidden).html_safe end def to_boolean_select_tag(options = {}) diff --git a/actionpack/test/template/form_helper_test.rb b/actionpack/test/template/form_helper_test.rb index 4b9e418..77623da 100644 --- a/actionpack/test/template/form_helper_test.rb +++ b/actionpack/test/template/form_helper_test.rb @@ -230,36 +230,36 @@ class FormHelperTest < ActionView::TestCase def test_check_box assert_dom_equal( - '', + '', check_box("post", "secret") ) @post.secret = 0 assert_dom_equal( - '', + '', check_box("post", "secret") ) assert_dom_equal( - '', + '', check_box("post", "secret" ,{"checked"=>"checked"}) ) @post.secret = true assert_dom_equal( - '', + '', check_box("post", "secret") ) assert_dom_equal( - '', + '', check_box("post", "secret?") ) @post.secret = ['0'] assert_dom_equal( - '', + '', check_box("post", "secret") ) @post.secret = ['1'] assert_dom_equal( - '', + '', check_box("post", "secret") ) end @@ -267,7 +267,7 @@ class FormHelperTest < ActionView::TestCase def test_check_box_with_explicit_checked_and_unchecked_values @post.secret = "on" assert_dom_equal( - '', + '', check_box("post", "secret", {}, "on", "off") ) end @@ -275,11 +275,11 @@ class FormHelperTest < ActionView::TestCase def test_check_box_with_multiple_behavior @post.comment_ids = [2,3] assert_dom_equal( - '', + '', check_box("post", "comment_ids", { :multiple => true }, 1) ) assert_dom_equal( - '', + '', check_box("post", "comment_ids", { :multiple => true }, 3) ) end @@ -287,7 +287,7 @@ class FormHelperTest < ActionView::TestCase def test_checkbox_disabled_still_submits_checked_value assert_dom_equal( - '', + '', check_box("post", "secret", { :disabled => :true }) ) end @@ -407,7 +407,7 @@ class FormHelperTest < ActionView::TestCase text_area("post", "body", "name" => "really!") ) assert_dom_equal( - '', + '', check_box("post", "secret", "name" => "i mean it") ) assert_dom_equal text_field("post", "title", "name" => "dont guess"), @@ -427,7 +427,7 @@ class FormHelperTest < ActionView::TestCase text_area("post", "body", "id" => "really!") ) assert_dom_equal( - '', + '', check_box("post", "secret", "id" => "i mean it") ) assert_dom_equal text_field("post", "title", "id" => "dont guess"), @@ -447,7 +447,7 @@ class FormHelperTest < ActionView::TestCase text_area("post", "body", "id" => nil) ) assert_dom_equal( - '', + '', check_box("post", "secret", "id" => nil) ) assert_dom_equal( @@ -478,7 +478,7 @@ class FormHelperTest < ActionView::TestCase text_area("post", "body", "index" => 5) ) assert_dom_equal( - '', + '', check_box("post", "secret", "index" => 5) ) assert_dom_equal( @@ -505,7 +505,7 @@ class FormHelperTest < ActionView::TestCase text_area("post", "body", "index" => 5, 'id' => nil) ) assert_dom_equal( - '', + '', check_box("post", "secret", "index" => 5, 'id' => nil) ) assert_dom_equal( @@ -536,7 +536,7 @@ class FormHelperTest < ActionView::TestCase text_area("post[]", "body") ) assert_dom_equal( - "", + "", check_box("post[]", "secret") ) assert_dom_equal( @@ -559,7 +559,7 @@ class FormHelperTest < ActionView::TestCase text_area("post[]", "body", :id => nil) ) assert_dom_equal( - "", + "", check_box("post[]", "secret", :id => nil) ) assert_dom_equal( @@ -588,8 +588,8 @@ class FormHelperTest < ActionView::TestCase "" + "" + "" + - "" + "" + + "" + "" + "" @@ -609,8 +609,8 @@ class FormHelperTest < ActionView::TestCase "" + "" + "" + - "" + "" + + "" + "" end @@ -629,8 +629,8 @@ class FormHelperTest < ActionView::TestCase expected = whole_form("http://www.example.com", "create-post", nil, "put") do "" + "" + - "" + - "" + "" + + "" end assert_dom_equal expected, output_buffer @@ -648,8 +648,8 @@ class FormHelperTest < ActionView::TestCase expected = whole_form("http://www.example.com", "create-post", nil, :method => "put", :remote => true) do "" + "" + - "" + - "" + "" + + "" end assert_dom_equal expected, output_buffer @@ -667,8 +667,8 @@ class FormHelperTest < ActionView::TestCase expected = whole_form("http://www.example.com", nil, nil, :remote => true) do "" + "" + - "" + - "" + "" + + "" end assert_dom_equal expected, output_buffer @@ -684,8 +684,8 @@ class FormHelperTest < ActionView::TestCase expected = whole_form("http://www.example.com", "create-post") do "" + "" + - "" + - "" + "" + + "" end assert_dom_equal expected, output_buffer @@ -705,8 +705,8 @@ class FormHelperTest < ActionView::TestCase "" + "" + "" + - "" + - "" + "" + + "" end assert_dom_equal expected, output_buffer @@ -724,8 +724,8 @@ class FormHelperTest < ActionView::TestCase expected = whole_form do "" + "" + - "" + - "" + "" + + "" end assert_dom_equal expected, output_buffer @@ -1296,8 +1296,8 @@ class FormHelperTest < ActionView::TestCase expected = "" + "" + - "" + - "" + "" + + "" assert_dom_equal expected, output_buffer end @@ -1312,8 +1312,8 @@ class FormHelperTest < ActionView::TestCase expected = "" + "" + - "" + - "" + "" + + "" assert_dom_equal expected, output_buffer end @@ -1328,8 +1328,8 @@ class FormHelperTest < ActionView::TestCase expected = "" + "" + - "" + - "" + "" + + "" assert_dom_equal expected, output_buffer end @@ -1344,8 +1344,8 @@ class FormHelperTest < ActionView::TestCase expected = "" + "" + - "" + - "" + "" + + "" assert_dom_equal expected, output_buffer end @@ -1360,8 +1360,8 @@ class FormHelperTest < ActionView::TestCase expected = "" + "" + - "" + - "" + "" + + "" assert_dom_equal expected, output_buffer end @@ -1376,8 +1376,8 @@ class FormHelperTest < ActionView::TestCase expected = "" + "" + - "" + - "" + "" + + "" assert_dom_equal expected, output_buffer end @@ -1425,8 +1425,8 @@ class FormHelperTest < ActionView::TestCase snowman + "" + "" + - "" + "" + + "" "" assert_dom_equal expected, output_buffer @@ -1476,7 +1476,7 @@ class FormHelperTest < ActionView::TestCase expected = whole_form do "
" + "
" + - "
" + "
" end assert_dom_equal expected, output_buffer @@ -1524,7 +1524,7 @@ class FormHelperTest < ActionView::TestCase expected = whole_form do "
" + "
" + - "
" + "
" end assert_dom_equal expected, output_buffer @@ -1542,7 +1542,7 @@ class FormHelperTest < ActionView::TestCase expected = "
" + "
" + - "
" + "
" assert_dom_equal expected, output_buffer end