#5142 XmlMini.rename_key emits invalid xml with dasherize - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#5142 ✓stale

XmlMini.rename_key emits invalid xml with dasherize

Reported by Bernerd Schaefer | July 17th, 2010 @ 10:51 PM

This was reported as a bug in the Mongoid issue tracker, where Mongoid's "_id" and "_type" fields were renamed to "<-id>" and "<-type>" when serialized to XML.

Attached is a patch which tests the existing ActiveSupport::XmlMini#rename_key method's functionality, and additionally ignores leading and trailing underscores to ensure we emit valid XML.

0001-xmlminirename_key-emits-valid-xml-with-dasherize.patch 3.3 KB

Comments and changes to this ticket

Yehuda Katz (wycats) July 26th, 2010 @ 05:58 PM
- Importance changed from “” to “Low”
Committed :)
You flagged this item as spam.
Andrea Campi October 17th, 2010 @ 12:02 AM
- Tag changed from “activesupport, bug, patch” to “activesupport, bug, patch, state:resolved”
You flagged this item as spam.
Andrea Campi October 17th, 2010 @ 12:02 AM
- Tag changed from “activesupport, bug, patch, state:resolved” to “activesupport, bug, patch”
Yehuda (or any other committer), can you mark this as resolved?
Santiago Pastorino February 2nd, 2011 @ 04:29 PM
- State changed from “new” to “open”
This issue has been automatically marked as stale because it has not been commented on for at least three months.

The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
Santiago Pastorino February 2nd, 2011 @ 04:29 PM
- State changed from “open” to “stale”