This project is archived and is in readonly mode.
XmlMini.rename_key emits invalid xml with dasherize
This was reported as a bug in the Mongoid issue tracker, where Mongoid's "_id" and "_type" fields were renamed to "<-id>" and "<-type>" when serialized to XML.
Attached is a patch which tests the existing ActiveSupport::XmlMini#rename_key method's functionality, and additionally ignores leading and trailing underscores to ensure we emit valid XML.
-
-
Andrea Campi- Tag changed from activesupport, bug, patch to activesupport, bug, patch, state:resolved
-
Andrea Campi
- Tag changed from activesupport, bug, patch, state:resolved to activesupport, bug, patch
Yehuda (or any other committer), can you mark this as resolved?
-
Santiago Pastorino- State changed from new to open
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
Santiago Pastorino
- State changed from open to stale