This project is archived and is in readonly mode.
[Patch] Ignore asset host for relative uri with host
According to URI rfc this is relative uri with host but without scheme:
//example.com/test
Currently rails handles such uri incorrectly when assets host set. It adds asset host to such urls, and that is incorrect,
This commit (in attach) fixes problem.
-
assets_uri.diff
2.19 KB
-
valodzka- Title changed from Ignore asset host for relative uri with host to [Patch] Ignore asset host for relative uri with host
- Assigned user set to Pratik
-
Andrea Campi- Tag changed from absolutepath, asset_host, patch, url to absolutepath, asset_host, patch, rails3, url
+1 looks good and tests pass
-
Santiago Pastorino- State changed from new to open
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
Santiago Pastorino
- State changed from open to stale
-
sergey.kojin
Problem is still here, I'm get it when tried to use jquery from google CDN.
I'm rewrite patch for rails3 edge.-
protocol_relative_url.diff
2.13 KB
-
-
sergey.kojin
- State changed from stale to open
Here is patch with tests only, to see that problem is really here. [state:open]
-
protocol_relative_url_tests.diff
1.55 KB
-
sergey.kojin
- Assigned user changed from Pratik to José Valim
-
-
José Valim- State changed from open to resolved
- Importance changed from to Low