Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

ActionDispatch::ShowException always calls rescue_action_locally if there is a reverse_proxy

#5166

The problem is on our staging environment with Rails 3 all errors are rendered with full exception details.

We have tracked this down to the ShowExcpetions middleware w/ a reverse proxy.

When the request comes in, Nginx sets the remote_addr to be 127.0.0.1 because the reverse proxy is on the same host. ActionDispatch::ShowExceptions#local_request? is always returning true because according to the env hash it is a local request.

It seems to me this method should use the action_dispatch.remote_ip if it is available. The RemoteIp middleware is configured after the ShowExceptions middleware.

We can create a patch if this is in fact a bug and not desired behaviour.

Reported by Adam · July 21st, 2010 @ 01:08 AM

State: stale
Milestone: none
Assigned to: nobody
Importance: none

Activity

  1. Santiago Pastorino
    Santiago Pastorino
    • State changed from new to open

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

    February 2nd, 2011 @ 04:51 PM

  2. Santiago Pastorino
    Santiago Pastorino
    • State changed from open to stale

    February 2nd, 2011 @ 04:51 PM