Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

There was a problem

You must be a member of this account.

This project is archived and is in readonly mode.

Id and parameter in path is not properly escaped for ActiveResource

#5173

Hi,
we use in project as id sometime also unique strings and it can contain space. Rails doesn't work in that case and doesn't escape it.
I attach fix which add escaping also for parameters in path. (patch is again 2.3.8 if you find it suitable I can do it also for master)

Reported by Josef Reidinger · July 21st, 2010 @ 03:46 PM

State: resolved
Milestone: 3.0.2
Assigned to: José Valim José Valim
Importance: Low

Activity

  1. Josef Reidinger
    Josef Reidinger
    • Assigned user set to Rick

    July 21st, 2010 @ 03:50 PM

  2. José Valim
    José Valim
    • Milestone cleared.
    • State changed from new to open
    • Assigned user changed from Rick to José Valim
    • Importance changed from to Low

    Great! Please also do provide a patch for master!

    July 21st, 2010 @ 09:11 PM

  3. Josef Reidinger
    Josef Reidinger
    • Assigned user changed from José Valim to Rick

    Here is patch against master. Also please note that in patch for 2.3 branch is unnecessary changes to require in test file( I again run into issue with shoulda and mocha and it is easy quick workaround - http://blog.anlek.com/2009/10/uninitialized-constant-test-unit-test...)
    thanks

    July 22nd, 2010 @ 07:44 AM

  4. Josef Reidinger
  5. Josef Reidinger
    Josef Reidinger
    • Assigned user changed from Rick to José Valim

    July 22nd, 2010 @ 07:46 AM

  6. José Valim
    José Valim
    • State changed from open to resolved

    Applied:

    http://github.com/rails/rails/commit/0e969bdaf8ff2e3384350687aa0b58...

    Unfortunately I pointed to the wrong ticket in the message. :P

    July 26th, 2010 @ 06:43 PM

  7. Jeremy Kemper