This project is archived and is in readonly mode.

#5215 ✓ committed
Simon Jefford

Configurable tld_length for subdomains

Reported by Simon Jefford | July 27th, 2010 @ 03:43 PM

I just watched the RailsCast on subdomains and it struck me that calling request.subdomain(tld_length) isn't very maintainable. Please find attached a patch that adds a configurable tld_length to ActionDispatch.

The only thing missing in the patch is a test for the Railtie part. I've manually tested it in an app but I wasn't sure as to the best way to go about writing a unit test for it.

Comments and changes to this ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Tickets have moved to Github

The new ticket tracker is available at https://github.com/rails/rails/issues

Shared Ticket Bins

Pages