This project is archived and is in readonly mode.
Configurable tld_length for subdomains
Reported by Simon Jefford | July 27th, 2010 @ 03:43 PM
I just watched the RailsCast on subdomains and it struck me that calling request.subdomain(tld_length) isn't very maintainable. Please find attached a patch that adds a configurable tld_length to ActionDispatch.
The only thing missing in the patch is a test for the Railtie part. I've manually tested it in an app but I wasn't sure as to the best way to go about writing a unit test for it.
Comments and changes to this ticket
-
Simon Jefford July 27th, 2010 @ 04:00 PM
Figured out where the initializer tests are. I've attached a new patch.
-
-
-
Simon Jefford September 11th, 2010 @ 11:32 AM
This has now been applied by wycats via a pull request to rails/rails and can now be closed.
-
Santiago Pastorino September 12th, 2010 @ 02:04 AM
- State changed from “new” to “committed”
- Importance changed from “” to “Low”
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
Jeremy Kemper
Mislav
Santiago Pastorino
Simon Jefford