This project is archived and is in readonly mode.
ShowExceptions middleware causes TypeError while logging a template error
#5238
While the template returns an error with annoteted_source_code in nil, the error_log handler throws yet another error inside, and ends in 500.
Here's a tiny scenario to reproduce the bug.
gem 'haml'
and bundle, then create a simple Haml view throwing a Ruby syntax
error, like this.
- else
Then start your server and send a request.Firstly, Haml throws an error with nil annoteted_source_code, next ShowExceptions middleware catches the error, then finally ShowExceptions middleware abends by being trapped in a TypeError.
Here's a patch not to cause a TypeError when annoteted_source_code is nil.
-
José Valim- Milestone cleared.
- State changed from new to resolved
- Assigned user set to José Valim
- Importance changed from to Low
This was fixed some time ago in master already, thanks!
-
