This project is archived and is in readonly mode.
Undefined behavior for translate(nil)
It's currently not defined what result you get when you call translate(nil), not in rails and not in i18n. To make things worse, the behavior changed from 2.3.5 to 2.3.8 to 3.0.0:
Loading development environment (Rails 2.3.5)
>> include ActionView::Helpers::TagHelper
>> include ActionView::Helpers::TranslationHelper
>> t(nil)
=> "<span class=\"translation_missing\">en</span>"
Loading development environment (Rails 2.3.8)
>> include ActionView::Helpers::TagHelper
>> include ActionView::Helpers::TranslationHelper
>> t(nil)
=> nil
Loading development environment (Rails 3.0.0.rc)
irb(main):002:0> include ActionView::Helpers::TagHelper
irb(main):003:0> include ActionView::Helpers::TranslationHelper
irb(main):004:0> t(nil)
=> "<span class=\"translation_missing\">en</span>"
As a starting point the attached patch adds a test that asserts the current behavior in 2.3.5 and 3.0.0.
But I think the current behavior is not very clever, because
IMHO it says 'translation missing' for a thing you can't
translate.
I think t(nil) should equal t(:nil), so you can translate the nil
string. What do you think?
-
Santiago Pastorino- State changed from new to open
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
Santiago Pastorino
- State changed from open to stale