This project is archived and is in readonly mode.
Rails3 RC - Named yield should return nil when content_for with that name was not called.
Reported by Robert Pankowecki | August 5th, 2010 @ 10:58 AM
Rails 2 allowed to easily create nested layouts. It's a bit harder in Rails3.
class TtController < ApplicationController
def index
render 'index', :layout => 'application'
end
def index2
render 'index2', :layout => 'mss'
end
end
In Rails3 you need to have:
# app/views/layouts/application.html.erb
<html>
<body>
<%= tmp = yield(:application) %>
<% if tmp.blank? %>
<%= yield %>
<% end%>
</body>
</html>
# app/views/layouts/mss.html.erb
<% content_for(:application) do %>
mss start
<%= tmp = yield(:mss) %>
<% if tmp.blank? %>
<%= yield %>
<% end %>
mss end
<% end %>
<%= render :file => 'layouts/application' %>
but in Rails 2 it could be much simpler:
# app/views/layouts/application.html.erb
<html>
<body>
<%= yield(:application) || yield %>
</body>
</html>
# app/views/layouts/mss.html.erb
<% content_for(:application) do %>
mss start
<%= yield(:mss) || yield %>
mss end
<% end %>
<%= render :file => 'layouts/application' %>
I think that current behavior should be changed to match Rails2 for simplicity and compatibility. As I showed it is useful for nested layouts. Also it is stated in Rails2 guides that it should work this way and I think we should stick with it.
Comments and changes to this ticket
-
Santiago Pastorino February 2nd, 2011 @ 05:00 PM
- State changed from “new” to “open”
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
Santiago Pastorino February 2nd, 2011 @ 05:00 PM
- State changed from “open” to “stale”
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
Bharat Ruparel
Neeraj Singh
Robert Pankowecki