This project is archived and is in readonly mode.
[PATCH] Load path for 1.9.2 in spec_helper.rb. No map method for string in 1.9.2
Hi, I attached patch which fixes load path in spec_helper.rb for
ruby 1.9.2.
Also it contains fix for missing String#map in ruby 1.9.2 in
Arel::Where#initializer.
-
Marjan Krekoten'- Tag changed from patch arel 1.9.2 to 1.9.2, arel, patch
-
Aaron Patterson- Importance changed from to Low
Please split this to two patches. Also, can you add the load path for "rake spec" rather than the spec helper?
Thanks!
-
Marjan Krekoten'
Sure, I'll do it.
-
Marjan Krekoten'
Sorry for taking too long.
Splited and fixed as you said :)-
001_arel_load_path_fix.patch
726 Bytes
-
002_arel_where_string_fix.patch
924 Bytes
-
-
Aaron Patterson
- State changed from new to incomplete
Hi Marjan, I've applied the 001 patch. Can you provide a test for the second patch? If I don't have a test, I'm afraid this fix will get regressed some day.
Thanks!
-
Marjan Krekoten'
Well, test is already exists in source. Under ruby 1.9.2-p0 engines/sql/unit/relations/where_spec.rb:43 fails with
NoMethodError in 'Arel::Where#to_sql when given a string passes the string through to the where clause' undefined method
map' for "asdf":StringSo that patch fixes this issue.
-
Aaron Patterson
- State changed from incomplete to committed
Doh! Sorry, I must be not thinking straight today. I've applied your patch. :-)