From ae592615b001a8cbb6a0e04f7895bcff51727dbf Mon Sep 17 00:00:00 2001 From: rohit Date: Thu, 2 Sep 2010 15:11:58 +0530 Subject: [PATCH 1/2] Failing test for GeneratedAttribute [#5461 state:open] --- .../test/generators/generated_attribute_test.rb | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/railties/test/generators/generated_attribute_test.rb b/railties/test/generators/generated_attribute_test.rb index de7e4de..272e179 100644 --- a/railties/test/generators/generated_attribute_test.rb +++ b/railties/test/generators/generated_attribute_test.rb @@ -108,4 +108,16 @@ class GeneratedAttributeTest < Rails::Generators::TestCase ) end end + + def test_nil_type_raises_exception + assert_raise Thor::Error do + create_generated_attribute(nil, 'title') + end + end + + def test_missing_type_raises_exception + assert_raise Thor::Error do + create_generated_attribute(:'', 'title') + end + end end -- 1.7.0.4 From 552a6dee14c8d66e736dcbf7b84710ce7cef0003 Mon Sep 17 00:00:00 2001 From: rohit Date: Thu, 2 Sep 2010 15:28:00 +0530 Subject: [PATCH 2/2] Output a friendly message when no type given for GeneratedAttribute [#5461 state:resolved] --- .../lib/rails/generators/generated_attribute.rb | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/railties/lib/rails/generators/generated_attribute.rb b/railties/lib/rails/generators/generated_attribute.rb index 3b9fff2..64273e4 100644 --- a/railties/lib/rails/generators/generated_attribute.rb +++ b/railties/lib/rails/generators/generated_attribute.rb @@ -6,6 +6,7 @@ module Rails attr_accessor :name, :type def initialize(name, type) + raise Thor::Error, "Missing type for attribute '#{name}'.\nExample: '#{name}:string' where string is the type." if type.blank? @name, @type = name, type.to_sym end -- 1.7.0.4