This project is archived and is in readonly mode.
Small performance improvement.
Reported by Thiago Pradi | August 30th, 2010 @ 05:31 AM
Hi Guys,
This patch is a small performace improvement on all_application_helpers method.
Comments and changes to this ticket
-
Santiago Pastorino August 30th, 2010 @ 06:08 AM
- State changed from “new” to “wontfix”
- Importance changed from “” to “Low”
Thiago, thanks for trying to improve Rails.
There's a lot of room for improvement but in this case why do you think this is an improvement?. You're changing two methods which modifies the helpers array instance (! methods) with two methods which returns new array instances so your patch make things work slower. -
Thiago Pradi August 30th, 2010 @ 01:38 PM
Hi Santiago,
Makes sense. I did a small benchmark and it seems to be faster. but when I changed to more iterations, it became slower. sorry for this Patch.
-
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
Jeremy Kemper
José Valim
Santiago Pastorino