Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Small performance improvement.

#5495

Hi Guys,

This patch is a small performace improvement on all_application_helpers method.

Reported by Thiago Pradi · August 30th, 2010 @ 05:31 AM

State: wontfix
Milestone: none
Assigned to: José Valim José Valim
Importance: Low

Activity

  1. Santiago Pastorino
    Santiago Pastorino
    • State changed from new to wontfix
    • Importance changed from to Low

    Thiago, thanks for trying to improve Rails.
    There's a lot of room for improvement but in this case why do you think this is an improvement?. You're changing two methods which modifies the helpers array instance (! methods) with two methods which returns new array instances so your patch make things work slower.

    August 30th, 2010 @ 06:08 AM

  2. Thiago Pradi
    Thiago Pradi

    Hi Santiago,

    Makes sense. I did a small benchmark and it seems to be faster. but when I changed to more iterations, it became slower. sorry for this Patch.

    August 30th, 2010 @ 01:38 PM

  3. Santiago Pastorino
    Santiago Pastorino

    No problem, thanks for trying Thiago ;)

    August 30th, 2010 @ 04:16 PM