From d11471796d757e2641b69b472d29fb4b264cb3e7 Mon Sep 17 00:00:00 2001 From: Nick Ragaz Date: Thu, 2 Sep 2010 00:36:18 -0400 Subject: [PATCH] failing test for reorder overriding default_scope --- activerecord/test/cases/relation_scoping_test.rb | 6 ++++++ activerecord/test/models/developer.rb | 2 +- 2 files changed, 7 insertions(+), 1 deletions(-) diff --git a/activerecord/test/cases/relation_scoping_test.rb b/activerecord/test/cases/relation_scoping_test.rb index cdfd62a..7feb6b7 100644 --- a/activerecord/test/cases/relation_scoping_test.rb +++ b/activerecord/test/cases/relation_scoping_test.rb @@ -389,6 +389,12 @@ class DefaultScopingTest < ActiveRecord::TestCase received = DeveloperOrderedBySalary.reorder('name DESC').collect { |dev| dev.name } assert_equal expected, received end + + def test_reordered_scope_overrides_default_scope_order + not_expected = DeveloperOrderedBySalary.first # Jamis -> name DESC + received = DeveloperOrderedBySalary.reordered_by_name.first # David -> name + refute_equal not_expected.id, received.id + end def test_nested_exclusive_scope expected = Developer.find(:all, :limit => 100).collect { |dev| dev.salary } diff --git a/activerecord/test/models/developer.rb b/activerecord/test/models/developer.rb index f0d40e7..947583a 100644 --- a/activerecord/test/models/developer.rb +++ b/activerecord/test/models/developer.rb @@ -88,7 +88,7 @@ class DeveloperOrderedBySalary < ActiveRecord::Base self.table_name = 'developers' default_scope :order => 'salary DESC' scope :by_name, order('name DESC') - scope :reordered_by_name, reorder('name DESC') + scope :reordered_by_name, reorder('name') def self.all_ordered_by_name with_scope(:find => { :order => 'name DESC' }) do -- 1.7.2.2