Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Add missing parenthesis

#5662

Attached patch adds missing parenthesis for respond_to? method. It' a good practice to add parenthesis while passing arguments to a method.

Reported by Anil Wadghule · September 19th, 2010 @ 03:46 PM

State: invalid
Milestone: none
Assigned to: José Valim José Valim
Importance: Low

Activity

  1. Anil Wadghule
    Anil Wadghule
    • Tag changed from consistent, parentheses to consistent

    September 19th, 2010 @ 03:46 PM

  2. Anil Wadghule
    Anil Wadghule

    Attaching patch file

    September 19th, 2010 @ 03:50 PM

  3. David Trasbo
    David Trasbo

    -1

    I disagree. It's only good practice to add parenthesis if it improves readability, e.g. if you have multiple method calls on a single line separated by if or unless.

    I this case the line has just that method call and it's perfectly clear what method the argument gets passed to.

    September 20th, 2010 @ 11:26 AM

  4. José Valim
    José Valim
    • State changed from new to invalid
    • Importance changed from to Low

    I agree with David. There is no need for adding parenthensis to these. In any case, keep up the good work Anil!

    September 24th, 2010 @ 11:33 AM