#5662 Add missing parenthesis - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#5662 ✓invalid

Add missing parenthesis

Reported by Anil Wadghule | September 19th, 2010 @ 03:46 PM

Attached patch adds missing parenthesis for respond_to? method. It' a good practice to add parenthesis while passing arguments to a method.

You flagged this item as spam.
Anil Wadghule September 19th, 2010 @ 03:46 PM
- Tag changed from “consistent, parentheses” to “consistent”
You flagged this item as spam.
Anil Wadghule September 19th, 2010 @ 03:50 PM
Attaching patch file
- add_parenthesis.diff 856 Bytes
David Trasbo September 20th, 2010 @ 11:26 AM
-1

I disagree. It's only good practice to add parenthesis if it improves readability, e.g. if you have multiple method calls on a single line separated by if or unless.

I this case the line has just that method call and it's perfectly clear what method the argument gets passed to.
José Valim September 24th, 2010 @ 11:33 AM
- State changed from “new” to “invalid”
- Importance changed from “” to “Low”
I agree with David. There is no need for adding parenthensis to these. In any case, keep up the good work Anil!