This project is archived and is in readonly mode.
rake db:structure:dump incorrectly uses the test environment adapter in error
Although the dump logic uses abcs[Rails.env]["adapter"], the error message uses abcs["test"]["adapter"]. This patch simply updates the error message to use the same selection as the case statement does.
I have generated patches against 2-3-stable and 3-0-stable, the 3.0 patch also applies cleanly to the current master (29f13bed "3.1.0.beta").
-
Repository- State changed from new to committed
(from [59ef0a2a5032d0e4dcc19be06c79b68f8f3c3b56]) db:structure:dump should list current Rails.env adapter in errors, not always the test adapter
[#5710 state:committed]
Signed-off-by: Santiago Pastorino santiago@wyeworks.com
http://github.com/rails/rails/commit/59ef0a2a5032d0e4dcc19be06c79b6... -
Repository
(from [f8c7f4cc5370b98ba93faeab49dcf9c37656920e]) db:structure:dump should list current Rails.env adapter in errors, not always the test adapter
[#5710 state:committed]
Signed-off-by: Santiago Pastorino santiago@wyeworks.com
http://github.com/rails/rails/commit/f8c7f4cc5370b98ba93faeab49dcf9... -
Santiago Pastorino
- State changed from committed to open
- Milestone set to 2.3.10
- Importance changed from to Low
This needs to be pushed on 2-3-stable
-
railsThis issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
rails
- State changed from open to stale