Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

hmt needlessly pushes join record onto through collection, duplicating create! action

#5823

Given a standard hmt setup, e.g. User <-> Membership <-> Group, user.groups << group persists just one Membership, but pushes the Membership onto the user instances memberships collection twice.

This should be left to through_association.create! to do, but the membership is manually pushed as well

Reported by Paul Bowsher · October 16th, 2010 @ 02:50 PM

State: stale
Milestone: none
Assigned to: nobody
Importance: none

Activity

  1. Paul Bowsher
    Paul Bowsher
    • Tag set to patch

    Patch attached. Tests passing (as far as I can tell)

    October 16th, 2010 @ 02:57 PM

  2. Santiago Pastorino
    Santiago Pastorino
    • State changed from new to open

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

    February 2nd, 2011 @ 04:30 PM

  3. Santiago Pastorino
    Santiago Pastorino
    • State changed from open to stale

    February 2nd, 2011 @ 04:30 PM