Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

ActiveRecord.column_names should not be mutable

#5857

I have an active record class named Bee. In the rails console

>> Bee.column_names
=> ["id", "created_at", "updated_at"]
>> Bee.column_names.delete 'id'
=> "id"
>> Bee.column_names
=> ["created_at", "updated_at"]

Bee.column_names should be immutable. I suggest the column_names implementation should read as follows instead

       # File activerecord/lib/active_record/base.rb, line 691
691:       def column_names
692:         @column_names = columns.map { |column| column.name }
693:       end

Reported by ogennadi · October 22nd, 2010 @ 04:31 PM

State: stale
Milestone: none
Assigned to: nobody
Importance: none

Activity

  1. Santiago Pastorino
    Santiago Pastorino
    • State changed from new to open

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

    February 2nd, 2011 @ 04:28 PM

  2. Santiago Pastorino
    Santiago Pastorino
    • State changed from open to stale

    February 2nd, 2011 @ 04:28 PM