This project is archived and is in readonly mode.

Arel adds needless conditions in after_initialize callback.

#5888

It's kind of hard for me to explain so here's the example.

class Account < AR:Base
  has_many :servers
end

class Server < AR:Base
  belongs_to :account

  after_initialize :set_hostname

  def set_hostname
    # I want to assign hostname for new record.
    puts Server.scoped.to_sql if new_record?
  end
end

Here's the behavior of arel-1.0.1.

irb> Server.new
SELECT "servers".* FROM "servers"
 => #<Server>

irb> Account.first.servers.new
SELECT "servers".* FROM "servers" WHERE ("servers".account_id = 1)
 => #<Server>

Arel adds account_id = 1 condition (which is needless). This occurs only in after_initialize callback.

Thanks.

Reported by Shouichi KAMIYA · October 29th, 2010 @ 07:03 PM

Activity

Jeff Kreeftmeijer
- Tag cleared.
- Importance changed from to Low
Automatic cleanup of spam.

November 1st, 2010 @ 05:03 PM
Santiago Pastorino
- State changed from new to open
This issue has been automatically marked as stale because it has not been commented on for at least three months.

The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

February 2nd, 2011 @ 04:20 PM
Santiago Pastorino
- State changed from open to stale
February 2nd, 2011 @ 04:20 PM