Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Wrong variable quoted in dbconsole error

#5916

When using an unknown database adapter, rails prints an error when running the db console (rails dbconsole) because it doesn't know the command to run. The error message incorrectly quotes the database name instead of the adapter.

This is my first patch to rails - please let me know if I've done anything incorrectly.

david

Reported by David Kelso · November 4th, 2010 @ 08:02 AM

State: open
Milestone: none
Assigned to: nobody
Importance: Low

Activity

  1. David Kelso
  2. David Kelso
  3. David Kelso
  4. Neeraj Singh
    Neeraj Singh
    • Importance changed from to Low

    +1 Looks good.

    can you mention if the patch is against Rails 2.3.10 or Rails3?

    November 4th, 2010 @ 10:49 AM

  5. David Kelso
    David Kelso

    The patch is against rails 3 edge. Is there a way to specify that with tags?

    November 4th, 2010 @ 06:47 PM

  6. Santiago Pastorino
    Santiago Pastorino
    • State changed from new to open

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

    February 5th, 2011 @ 08:56 PM

  7. Santiago Pastorino
    Santiago Pastorino
    • State changed from open to stale

    February 5th, 2011 @ 08:56 PM

  8. David Kelso
    David Kelso
    • State changed from stale to open

    [state:open]

    Yes, I can still reproduce the error on both stable and master. The patch still applies cleanly to both.
    It's a simple one line change. What is the best way to get this sort of thing committed?

    February 5th, 2011 @ 10:38 PM

  9. rails
    rails

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

    May 7th, 2011 @ 01:00 AM

  10. rails
    rails
    • State changed from open to stale

    May 7th, 2011 @ 01:00 AM

  11. David Kelso
    David Kelso
    • State changed from stale to open

    [state:open]

    C'mon guys. It's a one line patch.

    May 10th, 2011 @ 09:31 AM