#5954 [PATCH] ActiveRecord::Persistence#becomes does not ensure proper type - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#5954 ✓stale

[PATCH] ActiveRecord::Persistence#becomes does not ensure proper type

Reported by Dim | November 11th, 2010 @ 05:09 PM

Here an example:

class Employee < ActiveRecord::Base
end
class Manager < Employee
end

manager = Employee.new.becomes(Manager)
manager.class             # => Manager
manager.type              # => "Employee"
manager.save              # => #<Manager>
Employer.find(manager.id) # => #<Employee>

Patch plus test case are attached.

becomes.patch 3.5 KB

Comments and changes to this ticket

José Valim November 11th, 2010 @ 06:28 PM
- Importance changed from “” to “Low”
Great. Do you think you can provide a patch using git format-patch instead? You can get more information in the contributors guide: http://rails.lighthouseapp.com/projects/8994/sending-patches
José Valim November 11th, 2010 @ 06:28 PM
- Assigned user set to “José Valim”
Santiago Pastorino February 11th, 2011 @ 07:18 PM
- State changed from “new” to “open”
This issue has been automatically marked as stale because it has not been commented on for at least three months.

The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
Santiago Pastorino February 11th, 2011 @ 07:18 PM
- State changed from “open” to “stale”