This project is archived and is in readonly mode.

#5954 ✓ stale
Dim

[PATCH] ActiveRecord::Persistence#becomes does not ensure proper type

Reported by Dim | November 11th, 2010 @ 05:09 PM

Here an example:

class Employee < ActiveRecord::Base
end
class Manager < Employee
end

manager = Employee.new.becomes(Manager)
manager.class             # => Manager
manager.type              # => "Employee"
manager.save              # => #<Manager>
Employer.find(manager.id) # => #<Employee>

Patch plus test case are attached.

Comments and changes to this ticket

  • José Valim

    José Valim November 11th, 2010 @ 06:28 PM

    • Importance changed from “” to “Low”

    Great. Do you think you can provide a patch using git format-patch instead? You can get more information in the contributors guide: http://rails.lighthouseapp.com/projects/8994/sending-patches

  • José Valim

    José Valim November 11th, 2010 @ 06:28 PM

    • Assigned user set to “José Valim”
  • Santiago Pastorino

    Santiago Pastorino February 11th, 2011 @ 07:18 PM

    • State changed from “new” to “open”

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

  • Santiago Pastorino

    Santiago Pastorino February 11th, 2011 @ 07:18 PM

    • State changed from “open” to “stale”

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Tickets have moved to Github

The new ticket tracker is available at https://github.com/rails/rails/issues

Shared Ticket Bins

People watching this ticket

Attachments

Pages