Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Support MS SQL Server in Arel

#6069

Arel has problems with MS SQL Server; in particular specifying :limit generates invalid SQL.

I think MS SQL Server should be supported; it's a reasonably mainstream DB.

A possible solution has been created here [1].

The other solution considered was to override visit_Arel_Nodes_SelectCore and visit_Arel_Nodes_SelectStatement in the new Arel::Visitors::MSSQL class.

I can provide a suitable patch if I get guidance as to which approach is preferred.

[1] https://github.com/jabley/arel/compare/master...mssql

Reported by James Abley · November 26th, 2010 @ 11:23 AM

State: committed
Milestone: none
Assigned to: nobody
Importance: Low

Activity

  1. Deleted User
    Deleted User

    It looks like MSSQL is not widely used with RoR. But I had a chance to face to requirements for my app those led me to this ticket. James Abley done a great work, but it related to Arel 2.0.4. Since current version of Arel is 2.0.6 I ported provided patch into it and created a fork for Arel, here it is: https://github.com/pentagon/arel-2.0.6.

    I'll appreciate if these changes would go to master source tree.

    Special thanks to James Abley.

    December 28th, 2010 @ 10:50 AM

  2. Aaron Patterson
    Aaron Patterson
    • State changed from new to committed
    • Importance changed from to Low

    Thanks, I've applied this.

    January 3rd, 2011 @ 11:21 PM

  3. bingbing
    bingbing

    March 26th, 2011 @ 01:36 AM