This project is archived and is in readonly mode.
Add an #unmark_for_destruction method to ActiveRecord::AutosaveAssociation
At the moment, the only way to clear a mark for destruction from an association is to use #reload. This method also queries the database again and resets the attributes on the model. It is preferable to have an unmark_for_destruction method that accomplishes just the clearing of the flag.
To give an example of how this is helpful: if a method's default behavior is to destroy all associated records, except for a few that match certain characteristics, it is more intuitive to mark them all for destruction and then unmark the matching records.
I've attached a patch with tests.
Thanks,
-Mike
-
Mike Ragalietagged:activerecord tagged:autosave tagged:associations tagged:patch
-
Mike Ragalie
- Tag set to activerecord, associations, autosave, patch
[tagged:activerecord tagged:autosave tagged:associations tagged:patch]
-
rails- State changed from new to open
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
rails
- State changed from open to stale