This project is archived and is in readonly mode.

#6213 ✓stale

should pass table.engine in sanitize_sql_hash_for_conditions

Reported by bewang | December 22nd, 2010 @ 11:07 PM

class MyBase < ActiveRecord::Base

class Rule < MyBase
  has_many :rule_associations
  has_many :evaluations, :through=>:rule_associations, 
    :conditions => { 'join_table.column' => 'T' }


ActiveRecord will fail in sanitize_sql_hash_for_conditions with error like

[INFO]       undefined method `spec' for nil:NilClass (NoMethodError)
[INFO]       c:/temp/.m2/repository/.jruby/gems/arel-2.0.6/lib/arel/visitors.rb:26
[INFO]       c:/temp/.m2/repository/.jruby/gems/arel-2.0.6/lib/arel/visitors.rb:31:in `call'
[INFO]       c:/temp/.m2/repository/.jruby/gems/arel-2.0.6/lib/arel/visitors.rb:31:in `default'
[INFO]       c:/temp/.m2/repository/.jruby/gems/arel-2.0.6/lib/arel/visitors.rb:31:in `visitor_for'
[INFO]       c:/temp/.m2/repository/.jruby/gems/arel-2.0.6/lib/arel/nodes/node.rb:32:in `to_sql'
[INFO]       c:/temp/.m2/repository/.jruby/gems/activerecord-3.0.3/lib/active_record/base.rb:1296:in `sanitize_sql_hash_for_conditions'
[INFO]       c:/temp/.m2/repository/.jruby/gems/activerecord-3.0.3/lib/active_record/base.rb:1296:in `map'
[INFO]       c:/temp/.m2/repository/.jruby/gems/activerecord-3.0.3/lib/active_record/base.rb:1296:in `sanitize_sql_hash_for_conditions'
[INFO]       c:/temp/.m2/repository/.jruby/gems/activerecord-3.0.3/lib/active_record/base.rb:1225:in `sanitize_sql_for_conditions'

passing tabl.engine to b.to_sql fix the issue.

        def sanitize_sql_hash_for_conditions(attrs, default_table_name = self.table_name)
          attrs = expand_hash_conditions_for_aggregates(attrs)

          table =, :engine => arel_engine, :as => default_table_name)
          builder =
          builder.build_from_hash(attrs, table).map{ |b| b.to_sql *table.engine* }.join(' AND ')


Comments and changes to this ticket

  • rails

    rails March 23rd, 2011 @ 12:00 AM

    • State changed from “new” to “open”

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

  • rails

    rails March 23rd, 2011 @ 12:00 AM

    • State changed from “open” to “stale”

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href=""></a>

People watching this ticket