This project is archived and is in readonly mode.

#6235 ✓stale
JackC

ActiveRecord should not silently discard values it can't typecast

Reported by JackC | December 30th, 2010 @ 09:20 PM

When ActiveRecord is given a value for a field that can't be correctly typecast it sets the field to nil.

If this is an optional field that means that incorrect values will be silently discarded.

Even if a field is optional, it should not be silently thrown away.

Example below: optional birthdate is silently lost.

>> class Person < ActiveRecord::Base
>> end
=> nil
>> Person
=> Person(id: integer, name: string, birthdate: date)
>> Person.create :name => "John", :birthdate => "invalid"
=> #<Person id: 1, name: "John", birthdate: nil>

Comments and changes to this ticket

  • rails

    rails April 4th, 2011 @ 01:00 AM

    • State changed from “new” to “open”

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

  • rails

    rails April 4th, 2011 @ 01:00 AM

    • State changed from “open” to “stale”

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

People watching this ticket

Pages